CLN: Switch to pydantic for access field in metadata class #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
commented
Mar 19, 2024
src/fmu/dataio/datastructure/configuration/global_configuration.py
Outdated
Show resolved
Hide resolved
tnatt
commented
Mar 19, 2024
Comment on lines
-155
to
-166
| exclude_defaults=True, | ||
| exclude_none=True, | ||
| exclude_unset=True, |
There was a problem hiding this comment.
Dropping defaults and unset fields is not desired behavior, and lead to unwanted effects further in the execution. This is removed.
tnatt
force-pushed
the
use_pydantic_metadata_access
branch
from
f13eaee
to
ef37bf7
Compare
janbjorge
reviewed
Mar 19, 2024
| return config["masterdata"] | ||
|
|
||
|
|
||
| def generate_meta_access(config: dict) -> dict | None: |
janbjorge
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to replace the
generate_meta_accessfunction inside_metadatawith the pydanticAccessmodel instead.The logic inside this function has been replaced by pydantic, and will upon entering here already has been through the validation. Since we still allow an invalid config (pure object export), the current implementation did only run this function when finding a truthy
_config_is_validflag.