CLN: Move fmu_context validation for non-fmu runs to ExportData #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
reviewed
Mar 18, 2024
Comment on lines
-295
to
-308
| if not fmudata.get_provider(): # e.g. run from RMS not in a FMU run | ||
| actual_context = ( | ||
| FmuContext.PREPROCESSED | ||
| if self.dataio.fmu_context == FmuContext.PREPROCESSED | ||
| else FmuContext.get("non_fmu") | ||
| ) | ||
| if self.dataio.fmu_context != actual_context: | ||
| logger.warning( | ||
| "Requested fmu_context is <%s> but since this is detected as a non " | ||
| "FMU run, the actual context is force set to <%s>", | ||
| self.dataio.fmu_context, | ||
| actual_context, | ||
| ) | ||
| self.dataio.fmu_context = actual_context |
janbjorge
reviewed
Mar 18, 2024
tnatt
force-pushed
the
move_fmucontext_check
branch
from
e78dc7c
to
c08e594
Compare
janbjorge
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #529 and adds a
ExportData._fmurunattribute to eliminate the need for initializing a FmuProvider to detect the run environment.