Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Construct BoundingBox using pydantic #462

Merged
merged 1 commit into from
Feb 9, 2024
Merged

CLN: Construct BoundingBox using pydantic #462

merged 1 commit into from
Feb 9, 2024

Conversation

janbjorge
Copy link
Contributor

@janbjorge janbjorge commented Feb 9, 2024 •
edited
Loading

Addresses: #457

@janbjorge janbjorge self-assigned this Feb 9, 2024
mferrera
mferrera approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@janbjorge janbjorge merged commit 018c7c7 into equinor:main Feb 9, 2024
12 checks passed
@janbjorge janbjorge deleted the construct-boundingbox-using-pydantic branch February 9, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

@perolavsvendsen perolavsvendsen Awaiting requested review from perolavsvendsen

@ErichSuter ErichSuter Awaiting requested review from ErichSuter

Assignees

@janbjorge janbjorge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janbjorge @mferrera