-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Apply ERT env variables in FMU runs #451
Conversation
946a499
to
7e76d36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, my only comment is that i would have loved to see this split into two commits: One for the refactoring another for the new logic.
Also, please add a tag-prefix to the commit message.
I think that can be difficult to do (the two commits); but have split tests and examples + one change to pyproject.toml
Will fix |
This is a bigger PR where we go from parsing file paths in order to detect "running in FMU", to look for defined environment variables from ERT runs. In doing so, some refactorisering is done, in particular for the FmuProvider class to have a cleaner interface with the calling metadata.py module.
The examples now fake ERT environment variables
7e76d36
to
a522da7
Compare
This is a bigger PR where we go from parsing file paths in order to detect "running in FMU", to look for defined environment variables from ERT runs.
In doing so, some refactorisering is done, in particular for the _FmuProvider class (renamed to FmuProvider) to have a cleaner interface with the calling metadata.py module.
Resolves: #368