ENH: Apply ERT env variables in FMU runs #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
janbjorge
reviewed
Feb 5, 2024
jcrivenaes
force-pushed
the
apply-ert-env-variables
branch
4 times, most recently
from
946a499
to
7e76d36
Compare
janbjorge
reviewed
Feb 7, 2024
janbjorge
approved these changes
Feb 7, 2024
I think that can be difficult to do (the two commits); but have split tests and examples + one change to pyproject.toml
Will fix |
This is a bigger PR where we go from parsing file paths in order to detect "running in FMU", to look for defined environment variables from ERT runs. In doing so, some refactorisering is done, in particular for the FmuProvider class to have a cleaner interface with the calling metadata.py module.
The examples now fake ERT environment variables
jcrivenaes
force-pushed
the
apply-ert-env-variables
branch
from
7e76d36
to
a522da7
Compare
jcrivenaes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bigger PR where we go from parsing file paths in order to detect "running in FMU", to look for defined environment variables from ERT runs.
In doing so, some refactorisering is done, in particular for the _FmuProvider class (renamed to FmuProvider) to have a cleaner interface with the calling metadata.py module.
Resolves: #368