Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Extra parameters parsing tests #417

Merged
merged 1 commit into from
Jan 12, 2024
Merged

TST: Extra parameters parsing tests #417

merged 1 commit into from
Jan 12, 2024

Conversation

janbjorge
Copy link
Contributor

@janbjorge janbjorge commented Jan 11, 2024 •
edited
Loading

Test coverage hunting.

@janbjorge janbjorge self-assigned this Jan 11, 2024
@janbjorge janbjorge marked this pull request as ready for review January 11, 2024 18:48
@jcrivenaes
Copy link
Collaborator

Which issue/problem is targeted? Can you provide a description?

@janbjorge janbjorge changed the title Read parameters txt nested parameters dict tests TST: Read parameters txt nested parameters dict tests Jan 11, 2024
@janbjorge janbjorge changed the title TST: Read parameters txt nested parameters dict tests TST: Extra parameters parsing tests Jan 11, 2024
@janbjorge
Copy link
Contributor Author

Which issue/problem is targeted? Can you provide a description?

Just test coverage hunting.

jcrivenaes
jcrivenaes approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbjorge janbjorge merged commit e7198d0 into equinor:main Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrivenaes jcrivenaes jcrivenaes approved these changes

@mferrera mferrera Awaiting requested review from mferrera

@perolavsvendsen perolavsvendsen Awaiting requested review from perolavsvendsen

Assignees

@janbjorge janbjorge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janbjorge @jcrivenaes