Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add contributing document #415

Merged
merged 1 commit into from
Jan 12, 2024
Merged

DOC: Add contributing document #415

merged 1 commit into from
Jan 12, 2024

Conversation

janbjorge
Copy link
Contributor

@janbjorge janbjorge commented Jan 11, 2024

Copy of https://github.com/equinor/xtgeo/blob/main/docs/contributing.rst with some modifications (dropped the section about how to run stuff in RMS)

@janbjorge janbjorge self-assigned this Jan 11, 2024
@janbjorge janbjorge changed the title DOC: Add contributing docuemnt DOC: Add contributing document Jan 11, 2024
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perolavsvendsen and @jcrivenaes will have the final word but I'm not sure we want to start adding the commit prefixing here too

docs/contributing.rst Outdated Show resolved Hide resolved
Comment on lines 143 to 147
.. code-block:: text

API: an (incompatible) API change (will be rare)
BLD: change related to building fmu-dataio
BUG: bug fix
CLN: code cleanup, maintenance commit (refactoring, typos, PEP, etc.)
DEP: deprecate something, or remove a deprecated object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @perolavsvendsen and @jcrivenaes have might feel differently, but I don't think we should bring numpy-style commit prefixing into this repo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not made this convention for this repo (we have not actually discussed it either, yet).

docs/history.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Equinor requirements, there shall be a CONTRIBUTING.md (MarkDown format) in top level. This is recently done in xtgeo, and then the MarkDown is linked into the rst documentation tree via myst_parser. See https://github.com/equinor/xtgeo/blob/main/docs/contributing.rst

I propope you should do it in the same manner here.

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janbjorge janbjorge merged commit a8485ad into equinor:main Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants