Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove extension argument #412

Merged
merged 1 commit into from
Jan 12, 2024
Merged

CLN: Remove extension argument #412

merged 1 commit into from
Jan 12, 2024

Conversation

janbjorge
Copy link
Contributor

Addresses #411

@janbjorge janbjorge added the enhancement New feature or request label Jan 10, 2024
@janbjorge janbjorge self-assigned this Jan 10, 2024
@janbjorge
Copy link
Contributor Author

@mferrera @perolavsvendsen @jcrivenaes Unsure if ive gone to far here. But it feels like it should work like this?

@mferrera
Copy link
Collaborator

This seems like a good change to me, but I don't know what edge cases might exist

@janbjorge janbjorge marked this pull request as ready for review January 11, 2024 08:52
jcrivenaes
jcrivenaes approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 that this is Ok; we can try 😅

@janbjorge janbjorge changed the title Remove extension argument CLN: Remove extension argument Jan 12, 2024
@janbjorge janbjorge merged commit f9cfb6e into equinor:main Jan 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrivenaes jcrivenaes jcrivenaes approved these changes

@mferrera mferrera Awaiting requested review from mferrera

@perolavsvendsen perolavsvendsen Awaiting requested review from perolavsvendsen

Assignees

@janbjorge janbjorge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janbjorge @mferrera @jcrivenaes