Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff as linter #405

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Use ruff as linter #405

merged 1 commit into from
Jan 9, 2024

Conversation

janbjorge
Copy link
Contributor

@janbjorge janbjorge commented Jan 8, 2024

Merge after: #404

@janbjorge janbjorge self-assigned this Jan 9, 2024
@janbjorge janbjorge added the enhancement New feature or request label Jan 9, 2024
@@ -138,7 +140,7 @@ def export_file(obj, filename, extension, flag=None):
elif extension == ".roff" and isinstance(obj, (xtgeo.Grid, xtgeo.GridProperty)):
obj.to_file(filename, fformat="roff")
elif extension == ".csv" and isinstance(obj, pd.DataFrame):
includeindex = True if flag == "include_index" else False
includeindex = flag == "include_index"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider comment about example, otherwise LGTM 👍

@janbjorge janbjorge changed the title Add ruff Use ruff as linter Jan 9, 2024
@janbjorge janbjorge merged commit e6a9285 into equinor:main Jan 9, 2024
9 checks passed
Comment on lines +216 to +218
cfg = {}

cfg = dict()
cfg = {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future PR could probably remove this duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants