Improve handling of warning when missing content #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_units/test_dataio.py
Outdated
| eobj = ExportData(config=globalconfig1) | ||
| mymeta = eobj.generate_metadata(regsurf) | ||
|
|
||
| assert mymeta["data"]["content"] == "unset" | ||
|
|
||
|
|
||
| def test_content_not_given_case(globalconfig1, regsurf): |
There was a problem hiding this comment.
We can revert to this at a later stage, but it's somewhat confusing with the term "case" as it will sometimes mean that we are creating case metadata (class: case) and sometimes that we are exporting data in a case context. Could possibly be confusing for new readers at some point...
There was a problem hiding this comment.
Good point; have fixed this now
perolavsvendsen
approved these changes
Oct 24, 2023
Address issue equinor#379 The handling of content is moved to _object_data_provider, and also check that warning is not issued when merging preprocessed data.
jcrivenaes
force-pushed
the
track-missing-content
branch
from
60fb519
to
7b4aa50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #379
The handling of content is moved to _object_data_provider, and also check that the fmu_context is not "case"