Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate metadata with prod url instead of dev #359

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

adnejacobsen
Copy link
Contributor

The first step in an attempt to introduce staging to the fmu schema. We would like to use the dev version of the schema in sumo-dev and the prod schema in sumo-prod. This will hopefully allow us to experiment and make changes to the structure of the schema and test it in sumo without the fear of introducing problems in production.

The plan is to make changes to the uploader where we will set $schema to the dev url if SUMO_ENV == dev. Otherwise the default value will remain, which is now the prod url.

@adnejacobsen adnejacobsen requested a review from a team August 15, 2023 08:48
Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the corresponding prod schema (on the endpoint) is actually being built and is available, I think we should make this change 👍

@adnejacobsen adnejacobsen merged commit 43e139b into main Aug 30, 2023
7 checks passed
@perolavsvendsen perolavsvendsen deleted the use-prod-schema branch February 13, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants