Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for mission definition controller #1978

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add tests for mission definition controller #1978

merged 2 commits into from
Jan 24, 2025

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Jan 24, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@aeshub aeshub added backend Backend related functionality improvement Improvement to existing functionality labels Jan 24, 2025
@aeshub aeshub self-assigned this Jan 24, 2025
@aeshub aeshub force-pushed the test-mission-definition-controller branch from 6d32db0 to 42c52fb Compare January 24, 2025 12:20
Christdej
Christdej approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub aeshub merged commit 12308c3 into equinor:main Jan 24, 2025
11 of 12 checks passed
@aeshub aeshub deleted the test-mission-definition-controller branch January 24, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@aeshub aeshub

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeshub @Christdej