Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inspections after isar mission accepted #1974

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Update inspections after isar mission accepted #1974

merged 1 commit into from
Jan 23, 2025

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Jan 23, 2025 •
edited by tsundvoll
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

oysand
oysand approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Christdej
Christdej requested changes Jan 23, 2025
View reviewed changes
backend/api/api.csproj Outdated Show resolved Hide resolved
@mrica-equinor mrica-equinor force-pushed the main branch 2 times, most recently from 422fb55 to c10b529 Compare January 23, 2025 11:49
Christdej
Christdej approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor merged commit 7529370 into equinor:main Jan 23, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

@oysand oysand oysand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrica-equinor @oysand @Christdej