Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant test helpers #1942

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove redundant test helpers #1942

merged 1 commit into from
Jan 15, 2025

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Jan 13, 2025 •
edited
Loading

Awaiting merge of #1941 before ready for review.

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@aeshub aeshub added backend Backend related functionality improvement Improvement to existing functionality labels Jan 13, 2025
@aeshub aeshub self-assigned this Jan 13, 2025
@aeshub aeshub marked this pull request as draft January 13, 2025 12:42
@aeshub aeshub marked this pull request as ready for review January 14, 2025 08:40
@aeshub aeshub force-pushed the remove-redundant-test-helpers branch from 8377b7c to 75707fe Compare January 14, 2025 08:48
Christdej
Christdej approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub
Remove test helpers for read or new objects
3d0ab6c 
These were added due to difficulties with shared databased across the tests
which have since been resolved.
@aeshub aeshub force-pushed the remove-redundant-test-helpers branch from 75707fe to 3d0ab6c Compare January 15, 2025 07:41
@aeshub aeshub merged commit 54e5d45 into equinor:main Jan 15, 2025
12 checks passed
@aeshub aeshub deleted the remove-redundant-test-helpers branch January 15, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@aeshub aeshub

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeshub @Christdej