Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make event handlers more deterministic #1920

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Make event handlers more deterministic #1920

merged 4 commits into from
Jan 9, 2025

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Jan 2, 2025 •
edited
Loading

Closes #1891

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality labels Jan 2, 2025
@andchiind andchiind self-assigned this Jan 2, 2025
@andchiind andchiind marked this pull request as draft January 2, 2025 08:52
@andchiind andchiind marked this pull request as ready for review January 2, 2025 09:19
@andchiind andchiind force-pushed the 1891-deterministic-event-handlers branch from 679b070 to f32f840 Compare January 2, 2025 09:26
@andchiind andchiind force-pushed the 1891-deterministic-event-handlers branch 2 times, most recently from ff01f30 to 403fe78 Compare January 6, 2025 10:01
@andchiind andchiind requested a review from oysand January 6, 2025 11:58
oysand
oysand approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind andchiind force-pushed the 1891-deterministic-event-handlers branch from 403fe78 to 3e8c9bc Compare January 9, 2025 08:01
@andchiind andchiind merged commit 20dd1aa into equinor:main Jan 9, 2025
12 checks passed
@andchiind andchiind deleted the 1891-deterministic-event-handlers branch January 9, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make MissionEventHandler events pass the relevant robot state in the event arguments
2 participants
@andchiind @oysand