Remove unused video stream object

backend/api.test/Client/RobotTests.cs

@@ -105,7 +105,6 @@ public async Task RobotIsNotCreatedWithAreaNotInInstallation()
                 Port = 3000,
                 CurrentInstallationCode = installation.InstallationCode,
                 CurrentAreaName = wrongArea.Name,
-                VideoStreams = []
             };
 
             string robotUrl = "/robots";

backend/api.test/Database/DatabaseUtilities.cs

@@ -190,7 +190,6 @@ public async Task<Robot> NewRobot(RobotStatus status, Installation installation,
                 SerialNumber = "0001",
                 CurrentInstallationCode = installation.InstallationCode,
                 CurrentAreaName = area?.Name,
-                VideoStreams = [],
                 Documentation = [],
                 Host = "localhost",
                 Port = 3000,

backend/api.test/Services/RobotService.cs

@@ -92,12 +92,6 @@ public async Task Create()
 
             var robotsBefore = await robotService.ReadAll(readOnly: true);
             int nRobotsBefore = robotsBefore.Count();
-            var videoStreamQuery = new CreateVideoStreamQuery
-            {
-                Name = "Front Camera",
-                Url = "localhost:5000",
-                Type = "mjpeg"
-            };
             var documentationQuery = new CreateDocumentationQuery
             {
                 Name = "Some document",
@@ -108,10 +102,6 @@ public async Task Create()
                 Name = "",
                 IsarId = "",
                 SerialNumber = "",
-                VideoStreams =
-                [
-                    videoStreamQuery
-                ],
                 Documentation =
                 [
                     documentationQuery

backend/api/Controllers/DeckController.cs

@@ -48,10 +48,10 @@ public async Task<ActionResult<IList<DeckResponse>>> GetDecks()
         }
 
         /// <summary>
-        /// List all decks in the Flotilla database
+        /// List all decks in the specified installation
         /// </summary>
         /// <remarks>
-        /// <para> This query gets all decks </para>
+        /// <para> This query gets all decks in specified installation</para>
         /// </remarks>
         [HttpGet("installation/{installationCode}")]
         [Authorize(Roles = Role.Any)]

backend/api/Controllers/InspectionFindingController.cs

@@ -49,7 +49,7 @@ public async Task<ActionResult<InspectionFinding>> AddFinding([FromBody] Inspect
         }
 
         /// <summary>
-        /// Get the full inspection against an isarTaskId
+        /// Get the full inspection for specified isarTaskId
         /// </summary>
         /// <remarks>
         /// </remarks>

backend/api/Controllers/Models/CreateRobotQuery.cs

@@ -18,8 +18,6 @@ public struct CreateRobotQuery
 
         public IList<CreateDocumentationQuery> Documentation { get; set; }
 
-        public IList<CreateVideoStreamQuery> VideoStreams { get; set; }
-
         public string Host { get; set; }
 
         public int Port { get; set; }

backend/api/Controllers/Models/RobotResponse.cs

@@ -24,8 +24,6 @@ public class RobotResponse
 
         public IList<DocumentInfo> Documentation { get; set; }
 
-        public IList<VideoStream> VideoStreams { get; set; }
-
         public string Host { get; set; }
 
         public int Port { get; set; }
@@ -63,7 +61,6 @@ public RobotResponse(Robot robot)
             BatteryLevel = robot.BatteryLevel;
             PressureLevel = robot.PressureLevel;
             Documentation = robot.Documentation;
-            VideoStreams = robot.VideoStreams;
             Host = robot.Host;
             Port = robot.Port;
             IsarConnected = robot.IsarConnected;

backend/api/Controllers/RobotController.cs

@@ -373,84 +373,6 @@ [FromBody] RobotStatus robotStatus
             }
         }
 
-        /// <summary>
-        ///     Get video streams for a given robot
-        /// </summary>
-        /// <remarks>
-        ///     <para> Retrieves the video streams available for the given robot </para>
-        /// </remarks>
-        [HttpGet]
-        [Authorize(Roles = Role.User)]
-        [Route("{robotId}/video-streams/")]
-        [ProducesResponseType(typeof(IList<VideoStream>), StatusCodes.Status200OK)]
-        [ProducesResponseType(StatusCodes.Status400BadRequest)]
-        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-        [ProducesResponseType(StatusCodes.Status403Forbidden)]
-        [ProducesResponseType(StatusCodes.Status404NotFound)]
-        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
-        public async Task<ActionResult<IList<VideoStream>>> GetVideoStreams([FromRoute] string robotId)
-        {
-            var robot = await robotService.ReadById(robotId, readOnly: true);
-            if (robot == null)
-            {
-                logger.LogWarning("Could not find robot with id={Id}", robotId);
-                return NotFound();
-            }
-
-            return Ok(robot.VideoStreams);
-        }
-
-        /// <summary>
-        ///     Add a video stream to a given robot
-        /// </summary>
-        /// <remarks>
-        ///     <para> Adds a provided video stream to the given robot </para>
-        /// </remarks>
-        [HttpPost]
-        [Authorize(Roles = Role.Admin)]
-        [Route("{robotId}/video-streams/")]
-        [ProducesResponseType(typeof(RobotResponse), StatusCodes.Status201Created)]
-        [ProducesResponseType(StatusCodes.Status400BadRequest)]
-        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-        [ProducesResponseType(StatusCodes.Status403Forbidden)]
-        [ProducesResponseType(StatusCodes.Status404NotFound)]
-        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
-        public async Task<ActionResult<RobotResponse>> CreateVideoStream(
-            [FromRoute] string robotId,
-            [FromBody] VideoStream videoStream
-        )
-        {
-            var robot = await robotService.ReadById(robotId, readOnly: true);
-            if (robot == null)
-            {
-                logger.LogWarning("Could not find robot with id={Id}", robotId);
-                return NotFound();
-            }
-
-            robot.VideoStreams.Add(videoStream);
-
-            try
-            {
-                var updatedRobot = await robotService.Update(robot);
-                var robotResponse = new RobotResponse(updatedRobot);
-
-                return CreatedAtAction(
-                    nameof(GetVideoStreams),
-                    new
-                    {
-                        robotId = updatedRobot.Id
-                    },
-                    robotResponse
-                );
-            }
-            catch (Exception ex)
-            {
-                logger.LogError(ex, "Error adding video stream to robot");
-                throw;
-            }
-        }
-
-
         /// <summary>
         ///     Stops the current mission on a robot
         /// </summary>

backend/api/Database/Context/FlotillaDbContext.cs

@@ -68,7 +68,6 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
             modelBuilder.Entity<MissionRun>().OwnsOne(m => m.Map).OwnsOne(b => b.Boundary);
             modelBuilder.Entity<Robot>().OwnsOne(r => r.Pose).OwnsOne(p => p.Orientation);
             modelBuilder.Entity<Robot>().OwnsOne(r => r.Pose).OwnsOne(p => p.Position);
-            modelBuilder.Entity<Robot>().OwnsMany(r => r.VideoStreams);
 
             modelBuilder.Entity<DefaultLocalizationPose>().OwnsOne(d => d.Pose, poseBuilder =>
             {

backend/api/Database/Context/InitDb.cs

@@ -17,14 +17,6 @@ public static class InitDb
         private static readonly List<MissionRun> missionRuns = GetMissionRuns();
         private static readonly List<AccessRole> accessRoles = GetAccessRoles();
 
-        private static VideoStream VideoStream =>
-            new()
-            {
-                Name = "Front camera",
-                Url = "http://localhost:5000/stream?topic=/camera/rgb/image_raw",
-                Type = "mjpeg"
-            };
-
         private static List<Inspection> GetInspections()
         {
             var inspection1 = new Inspection
@@ -313,7 +305,6 @@ private static List<Robot> GetRobots()
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallation = installations[0],
-                VideoStreams = [],
                 Documentation = [],
                 Pose = new Pose()
             };
@@ -327,7 +318,6 @@ private static List<Robot> GetRobots()
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallation = installations[0],
-                VideoStreams = [],
                 Documentation = [],
                 Pose = new Pose()
             };
@@ -341,7 +331,6 @@ private static List<Robot> GetRobots()
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallation = installations[0],
-                VideoStreams = [],
                 Documentation = [],
                 Pose = new Pose()
             };
@@ -692,8 +681,6 @@ public static void PopulateDb(FlotillaDbContext context)
             context.AddRange(inspections);
             context.AddRange(installations);
             AddRobotModelsToContext(context);
-            foreach (var robot in robots)
-                robot.VideoStreams.Add(VideoStream);
             context.SaveChanges();
             var models = context.RobotModels.AsTracking().AsEnumerable().ToList();
             robots[0].Model = models.Find(model => model.Type == RobotType.TaurobInspector)!;

backend/api/Database/Models/Robot.cs

@@ -9,7 +9,6 @@ public class Robot
         public Robot()
         {
             Documentation = [];
-            VideoStreams = [];
             IsarId = "defaultIsarId";
             Name = "defaultId";
             SerialNumber = "defaultSerialNumber";
@@ -23,18 +22,6 @@ public Robot()
 
         public Robot(CreateRobotQuery createQuery, Installation installation, RobotModel model, Area? area = null)
         {
-            var videoStreams = new List<VideoStream>();
-            foreach (var videoStreamQuery in createQuery.VideoStreams)
-            {
-                var videoStream = new VideoStream
-                {
-                    Name = videoStreamQuery.Name,
-                    Url = videoStreamQuery.Url,
-                    Type = videoStreamQuery.Type
-                };
-                videoStreams.Add(videoStream);
-            }
-
             var documentation = new List<DocumentInfo>();
             foreach (var documentQuery in createQuery.Documentation)
             {
@@ -52,7 +39,6 @@ public Robot(CreateRobotQuery createQuery, Installation installation, RobotModel
             CurrentInstallation = installation;
             CurrentArea = area;
             Documentation = documentation;
-            VideoStreams = videoStreams;
             Host = createQuery.Host;
             Port = createQuery.Port;
             IsarConnected = true;
@@ -117,8 +103,6 @@ public bool IsRobotReadyToStartMissions()
 
         public IList<DocumentInfo> Documentation { get; set; }
 
-        public IList<VideoStream> VideoStreams { get; set; }
-
         [Required]
         [MaxLength(200)]
         public string Host { get; set; }