Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use echo inspection target name as tag description #1858

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Use echo inspection target name as tag description #1858

merged 2 commits into from
Dec 10, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 10, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol force-pushed the tag-description branch 3 times, most recently from c73636d to ac7aa79 Compare December 10, 2024 10:09
@Eddasol Eddasol self-assigned this Dec 10, 2024
@Eddasol Eddasol added feature New feature or request backend Backend related functionality labels Dec 10, 2024
@Eddasol Eddasol force-pushed the tag-description branch 2 times, most recently from db58418 to c39bf0c Compare December 10, 2024 11:30
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 10, 2024
@Eddasol Eddasol marked this pull request as ready for review December 10, 2024 11:33
@Eddasol Eddasol force-pushed the tag-description branch 3 times, most recently from 43cd552 to ccfbeac Compare December 10, 2024 12:28
mrica-equinor
mrica-equinor approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Eddasol
Copy link
Contributor Author

Eddasol commented Dec 10, 2024

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 0204d48 into equinor:main Dec 10, 2024
13 checks passed
@Eddasol Eddasol deleted the tag-description branch December 10, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrica-equinor mrica-equinor mrica-equinor approved these changes

Assignees

@Eddasol Eddasol

Labels
backend Backend related functionality database-change Will require migration feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @mrica-equinor