-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable schedule mission button when no robots available #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
added
improvement
Improvement to existing functionality
frontend
Frontend related functionality
labels
Dec 22, 2023
andchiind
force-pushed
the
1182-remove-buttons
branch
3 times, most recently
from
December 27, 2023 08:50
2029372
to
b7f420a
Compare
andchiind
changed the title
Simplify InspectionSection
Disable schedule mission button when no robots available
Dec 27, 2023
andchiind
force-pushed
the
1182-remove-buttons
branch
3 times, most recently
from
January 4, 2024 08:27
8aec518
to
6347dfd
Compare
andchiind
force-pushed
the
1182-remove-buttons
branch
from
January 4, 2024 14:50
6347dfd
to
4ba2338
Compare
andchiind
force-pushed
the
1182-remove-buttons
branch
3 times, most recently
from
January 12, 2024 12:48
5c2bf56
to
00d07a8
Compare
Eddasol
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As last commit is only formatting, it can be squashed into relevant commit
frontend/src/components/Pages/InspectionPage/InspectionOverview.tsx
Outdated
Show resolved
Hide resolved
Eddasol
reviewed
Jan 15, 2024
Eddasol
reviewed
Jan 15, 2024
andchiind
force-pushed
the
1182-remove-buttons
branch
3 times, most recently
from
January 17, 2024 08:36
7c460fc
to
a5ad96f
Compare
Eddasol
reviewed
Jan 18, 2024
Eddasol
reviewed
Jan 18, 2024
frontend/src/components/Pages/InspectionPage/InspectionOverview.tsx
Outdated
Show resolved
Hide resolved
Eddasol
reviewed
Jan 18, 2024
frontend/src/components/Pages/InspectionPage/InspectionTable.tsx
Outdated
Show resolved
Hide resolved
Eddasol
reviewed
Jan 18, 2024
Eddasol
reviewed
Jan 18, 2024
Eddasol
reviewed
Jan 18, 2024
frontend/src/components/Pages/InspectionPage/InspectionTable.tsx
Outdated
Show resolved
Hide resolved
Eddasol
reviewed
Jan 18, 2024
andchiind
force-pushed
the
1182-remove-buttons
branch
from
January 18, 2024 08:26
bfd6a3d
to
5527294
Compare
Eddasol
reviewed
Jan 18, 2024
frontend/src/components/Displays/LocalizationVerification/ScheduleMissionChecklistDialog.tsx
Show resolved
Hide resolved
frontend/src/components/Displays/LocalizationVerification/ScheduleMissionChecklistDialog.tsx
Show resolved
Hide resolved
frontend/src/components/Displays/LocalizationVerification/ScheduleMissionChecklistDialog.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Displays/LocalizationVerification/ScheduleMissionChecklistDialog.tsx
Show resolved
Hide resolved
Fix mission button not being disabled
andchiind
force-pushed
the
1182-remove-buttons
branch
2 times, most recently
from
January 24, 2024 14:40
4e012c9
to
ad90203
Compare
andchiind
force-pushed
the
1182-remove-buttons
branch
from
January 24, 2024 14:43
ad90203
to
4859134
Compare
andchiind
force-pushed
the
1182-remove-buttons
branch
from
January 25, 2024 11:24
b439dee
to
047dbe9
Compare
mrica-equinor
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1182
Also refactors the files related to it. It is best to check the PR commit by commit, since most of them are just refactoring. Some commits have more than one lines in their commit message.