Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable schedule mission button when no robots available #1292

Merged
merged 16 commits into from
Jan 25, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Dec 22, 2023

Closes #1182
Also refactors the files related to it. It is best to check the PR commit by commit, since most of them are just refactoring. Some commits have more than one lines in their commit message.

@andchiind andchiind added improvement Improvement to existing functionality frontend Frontend related functionality labels Dec 22, 2023
@andchiind andchiind self-assigned this Dec 22, 2023
@andchiind andchiind force-pushed the 1182-remove-buttons branch 3 times, most recently from 2029372 to b7f420a Compare December 27, 2023 08:50
@andchiind andchiind changed the title Simplify InspectionSection Disable schedule mission button when no robots available Dec 27, 2023
@andchiind andchiind force-pushed the 1182-remove-buttons branch 3 times, most recently from 8aec518 to 6347dfd Compare January 4, 2024 08:27
@andchiind andchiind force-pushed the 1182-remove-buttons branch from 6347dfd to 4ba2338 Compare January 4, 2024 14:50
@andchiind andchiind force-pushed the 1182-remove-buttons branch 3 times, most recently from 5c2bf56 to 00d07a8 Compare January 12, 2024 12:48
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As last commit is only formatting, it can be squashed into relevant commit

@andchiind andchiind force-pushed the 1182-remove-buttons branch 3 times, most recently from 7c460fc to a5ad96f Compare January 17, 2024 08:36
@andchiind andchiind requested a review from Eddasol January 17, 2024 08:49
@andchiind andchiind force-pushed the 1182-remove-buttons branch from bfd6a3d to 5527294 Compare January 18, 2024 08:26
@andchiind andchiind force-pushed the 1182-remove-buttons branch 2 times, most recently from 4e012c9 to ad90203 Compare January 24, 2024 14:40
@andchiind andchiind force-pushed the 1182-remove-buttons branch from ad90203 to 4859134 Compare January 24, 2024 14:43
@andchiind andchiind force-pushed the 1182-remove-buttons branch from b439dee to 047dbe9 Compare January 25, 2024 11:24
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andchiind andchiind merged commit 867bb73 into equinor:main Jan 25, 2024
11 checks passed
@andchiind andchiind deleted the 1182-remove-buttons branch January 25, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mission buttons available even if no robot is in the installation
3 participants