Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin opentelemetry #9969

Closed
wants to merge 2 commits into from
Closed

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Feb 5, 2025

Solves mypy ellipsis error (for now). Offending code:
@staticmethod
3 weeks ago

Add type checker (https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3116[)](https://github.com/open-telemetry/opentelemetry-python-contrib/commit/406707b2bd322b6fe5819a6123b0deee1c6f21d1)

    def __wrap_threading_start(
        call_wrapped: Callable[[], None],
        instance: HasOtelContext,
        args: ...,
        kwargs: ...,
    ) -> None:

@yngve-sk yngve-sk force-pushed the 25.02.05.debug-mypysmt branch from 5ec8b3d to 86b1106 Compare February 5, 2025 11:52
@yngve-sk yngve-sk changed the title Pin mypy<1.15.0 Pin opentelemetry Feb 5, 2025
@yngve-sk
Copy link
Contributor Author

yngve-sk commented Feb 5, 2025

Added commit to other PR: #9968

@yngve-sk yngve-sk force-pushed the 25.02.05.debug-mypysmt branch from 86b1106 to 5d25788 Compare February 5, 2025 12:09
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #9969 will degrade performances by 10.11%

Comparing yngve-sk:25.02.05.debug-mypysmt (5000c55) with main (e1f4eab)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.4 ms 1.6 ms -10.11%

@yngve-sk yngve-sk closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant