Fix workflows running from gui's tools panel not working #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
the
release-notes:bug-fix
|
Have you tested workflows with this PR? |
|
Does the workflows work if you run them as part of an ert run? (maybe the same that was meant with the above comment?) |
CodSpeed Performance ReportMerging #9954 will not alter performanceComparing Summary
|
Yes, both in GUI and with |
No, but I can add a workflow_hook and have it run as part of the experiment. |
jonathan-eq
force-pushed
the
fix-export-runpath-job
branch
from
0c4c3c2 to
a59107f
Compare
|
Some mypy errors: |
jonathan-eq
force-pushed
the
fix-export-runpath-job
branch
2 times, most recently
from
81c76e6 to
f732acb
Compare
This commit fixes the issue where most of the legacy workflows would not work due to ert_config not being passed to workflow_runner in run_workflow_widget. This commit refactors the workflow_runner/plugin_runner to not use ert_config directly; and instead only pass `ert_config.runpaths`
jonathan-eq
force-pushed
the
fix-export-runpath-job
branch
from
f732acb to
1524a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
This commit fixes the issue where most of the legacy workflows would not work due to ert_config not being passed to workflow_runner in run_workflow_widget.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable