Use only dots to delimit controls #9942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
25.02.03.make-names-consistent
branch
from
068c4ad to
2d25df7
Compare
CodSpeed Performance ReportMerging #9942 will improve performances by 10.15%Comparing Summary
Benchmarks breakdown
|
yngve-sk
force-pushed
the
25.02.03.make-names-consistent
branch
5 times, most recently
from
e6241f0 to
b084afc
Compare
verveerpj
approved these changes
Feb 5, 2025
Comment on lines
117
to
126
| def _get_control_index(name: str): | ||
| try: | ||
| matching_index = formatted_control_names.index(name.replace("-", ".")) | ||
| return matching_index | ||
| except ValueError: | ||
| pass | ||
|
|
||
| return formatted_control_names_dotdash.index(name) |
There was a problem hiding this comment.
Eventually this should disappear, since using the dash is deprecated. Maybe a comment?
yngve-sk
force-pushed
the
25.02.03.make-names-consistent
branch
from
b084afc to
6f66d73
Compare
yngve-sk
force-pushed
the
25.02.03.make-names-consistent
branch
from
6f66d73 to
3738bc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9816
Approach
Keep backward compatibility (should be deprecated?) but accept only
.notation to delimit control names, variable/index etc