Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uv lockfile #9561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 16, 2024

See https://docs.astral.sh/uv/guides/projects/

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the test_using_uv_lockfile branch from c5f5714 to e322772 Compare December 16, 2024 13:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (9ba5a28) to head (9b23882).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9561      +/-   ##
==========================================
- Coverage   91.90%   91.69%   -0.21%     
==========================================
  Files         433      433              
  Lines       26788    26788              
==========================================
- Hits        24619    24563      -56     
- Misses       2169     2225      +56     
Flag Coverage Δ
cli-tests 39.76% <ø> (+0.02%) ⬆️
everest-models-test ?
gui-tests 72.13% <ø> (-0.03%) ⬇️
integration-test 37.20% <ø> (+0.03%) ⬆️
performance-tests 51.95% <ø> (+0.01%) ⬆️
test 40.69% <ø> (+0.01%) ⬆️
unit-tests 74.17% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9561 will improve performances by 10.11%

Comparing larsevj:test_using_uv_lockfile (35d273a) with main (3f4a93e)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.5 ms 1.4 ms +10.11%

@larsevj larsevj force-pushed the test_using_uv_lockfile branch 2 times, most recently from 0028f57 to 9b23882 Compare December 19, 2024 14:25
@larsevj larsevj force-pushed the test_using_uv_lockfile branch from 9b23882 to 938bf65 Compare January 7, 2025 08:54
@larsevj larsevj force-pushed the test_using_uv_lockfile branch 5 times, most recently from 51bb4ab to fc33e82 Compare January 20, 2025 12:27
@larsevj larsevj force-pushed the test_using_uv_lockfile branch from fc33e82 to 5a16d21 Compare January 29, 2025 09:28
@larsevj larsevj marked this pull request as ready for review January 29, 2025 11:39
@larsevj larsevj changed the title Test out uv lockfile Add uv lockfile Jan 29, 2025
@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 29, 2025
@larsevj
Copy link
Contributor Author

larsevj commented Jan 29, 2025

No dependabot support as of yet, which might be a blocker. See dependabot/dependabot-core#10478 (comment)

@larsevj larsevj force-pushed the test_using_uv_lockfile branch from 5a16d21 to 66bfe4f Compare February 11, 2025 14:29
@larsevj larsevj force-pushed the test_using_uv_lockfile branch from 66bfe4f to 35d273a Compare February 11, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants