Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new hook for specifying config per forward model step #9050

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 25, 2024

Issue
Resolves #9036

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (cbaaca9) to head (859ec5d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/plugins/plugin_manager.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9050      +/-   ##
==========================================
+ Coverage   90.84%   90.86%   +0.02%     
==========================================
  Files         352      352              
  Lines       21746    21783      +37     
==========================================
+ Hits        19755    19793      +38     
+ Misses       1991     1990       -1     
Flag Coverage Δ
cli-tests 38.99% <22.72%> (-0.02%) ⬇️
gui-tests 72.51% <22.72%> (-0.07%) ⬇️
performance-tests 49.48% <22.72%> (-0.03%) ⬇️
unit-tests 79.62% <86.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pluginsystem to configure general key-value pairs pr forward model step
2 participants