Inject nohup to make sure that bkill executes after ert dies #8936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
reviewed
Oct 10, 2024
| @@ -414,7 +414,7 @@ async def kill(self, iens: int) -> None: | |||
| return_on_msgs=(JOB_ALREADY_FINISHED_BKILL_MSG), | |||
| ) | |||
| await asyncio.create_subprocess_shell( | |||
| f"sleep {self._sleep_time_between_bkills}; {self._bkill_cmd} -s SIGKILL {job_id}", | |||
| f"nohup sh -c 'sleep {self._sleep_time_between_bkills}; {self._bkill_cmd} -s SIGKILL {job_id}' &", | |||
There was a problem hiding this comment.
I thought this would work as we already have start_new_session=True. Can we remove that flag with nohup?
There was a problem hiding this comment.
As long as start_new_session works (I think it does until proven otherwise), start_new_session is the approach to go for.
There was a problem hiding this comment.
Haven't got to test it yet. If it works I'll close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After initiating terminate experiment a window can become unresponsive and thus user might ctrl+c / kill the main ert.
nohupmakes sure that the bkill will be executed.Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable