Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor everest tmpdir fixture #8885

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Oct 4, 2024

Issue
Resolves #8860

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad self-assigned this Oct 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (b505d33) to head (b6a7f62).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8885      +/-   ##
==========================================
+ Coverage   91.37%   91.53%   +0.16%     
==========================================
  Files         344      345       +1     
  Lines       21119    21252     +133     
==========================================
+ Hits        19297    19453     +156     
+ Misses       1822     1799      -23     
Flag Coverage Δ
cli-tests 39.59% <ø> (+0.06%) ⬆️
gui-tests 73.37% <ø> (-0.11%) ⬇️
performance-tests 50.17% <ø> (+0.02%) ⬆️
unit-tests 80.30% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frode-aarstad frode-aarstad changed the title Refactor everest math func fixture Refactor everest tmpdir fixture Oct 7, 2024
@frode-aarstad frode-aarstad marked this pull request as draft October 7, 2024 07:35
@frode-aarstad frode-aarstad force-pushed the refactor-tmpdir branch 2 times, most recently from d6c4032 to 7f56c57 Compare October 7, 2024 12:21
@frode-aarstad frode-aarstad marked this pull request as ready for review October 8, 2024 05:44
Copy link
Contributor

@verveerpj verveerpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small comments.

tests/everest/conftest.py Outdated Show resolved Hide resolved
tests/everest/test_everserver.py Show resolved Hide resolved
@frode-aarstad frode-aarstad force-pushed the refactor-tmpdir branch 2 times, most recently from fe09fdd to bee82b2 Compare October 9, 2024 10:14
@frode-aarstad frode-aarstad merged commit 16f3a13 into equinor:main Oct 9, 2024
56 checks passed
@frode-aarstad frode-aarstad deleted the refactor-tmpdir branch October 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update everest tmpdir functionality
3 participants