Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job label not updating when selecting same index #8512

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 19, 2024

Fixes bug where selecting the same indices from different tab would not update the label.
Moved label back just above the job_overview.

Screenshot 2024-08-19 at 14 48 12

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI release-notes:bug-fix Automatically categorise as bug fix in release notes and removed release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI labels Aug 19, 2024
@andreas-el andreas-el changed the title Fix job label not updating when same index Fix job label not updating when selecting same index Aug 19, 2024
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.62%. Comparing base (ccc2479) to head (2a71d6f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8512      +/-   ##
==========================================
+ Coverage   90.61%   90.62%   +0.01%     
==========================================
  Files         342      342              
  Lines       20895    20899       +4     
==========================================
+ Hits        18934    18940       +6     
+ Misses       1961     1959       -2     
Flag Coverage Δ
gui-tests 75.87% <100.00%> (-0.01%) ⬇️
integration-tests 54.03% <25.00%> (-0.01%) ⬇️
unit-tests 68.72% <25.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el merged commit 02f996b into equinor:main Aug 20, 2024
35 checks passed
@andreas-el andreas-el deleted the job_label_ids branch August 20, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants