Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect failed realizations after ert restart #7514

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/ert/gui/simulation/evaluate_ensemble_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def __init__(self, ensemble_size: int, run_path: str, notifier: ErtNotifier):
self._active_realizations_field.setValidator(
RangeStringArgument(ensemble_size),
)
self._realizations_from_fs()
layout.addRow("Active realizations", self._active_realizations_field)

self.setLayout(layout)
Expand All @@ -55,6 +56,7 @@ def __init__(self, ensemble_size: int, run_path: str, notifier: ErtNotifier):
self.simulationConfigurationChanged
)
self._ensemble_selector.ensemble_populated.connect(self._realizations_from_fs)
self._ensemble_selector.currentIndexChanged.connect(self._realizations_from_fs)

def isConfigurationValid(self):
return self._active_realizations_field.isValid()
Expand All @@ -65,11 +67,3 @@ def getSimulationArguments(self):
ensemble_name=self._ensemble_selector.currentText(),
realizations=self._active_realizations_field.text(),
)

def _realizations_from_fs(self):
ensemble = str(self._ensemble_selector.currentText())
if ensemble:
mask = self.notifier.storage.get_ensemble_by_name(
ensemble
).get_realization_mask_with_parameters()
self._active_realizations_field.model.setValueFromMask(mask)
8 changes: 6 additions & 2 deletions src/ert/gui/simulation/iterated_ensemble_smoother_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ def __init__(
self._name_field.setMinimumWidth(250)
layout.addRow("Experiment name:", self._name_field)

ensemble_selector = EnsembleSelector(notifier)
layout.addRow("Current ensemble:", ensemble_selector)
self._ensemble_selector = EnsembleSelector(notifier)
layout.addRow("Current ensemble:", self._ensemble_selector)

runpath_label = CopyableLabel(text=run_path)
layout.addRow("Runpath:", runpath_label)
Expand Down Expand Up @@ -91,6 +91,7 @@ def __init__(
self._active_realizations_model, "config/simulation/active_realizations"
)
self._active_realizations_field.setValidator(RangeStringArgument(ensemble_size))
self._realizations_from_fs()
layout.addRow("Active realizations", self._active_realizations_field)

self._iterated_target_ensemble_format_field.getValidationSupport().validationChanged.connect( # noqa
Expand All @@ -100,6 +101,9 @@ def __init__(
self.simulationConfigurationChanged
)

self._ensemble_selector.ensemble_populated.connect(self._realizations_from_fs)
self._ensemble_selector.currentIndexChanged.connect(self._realizations_from_fs)

self.setLayout(layout)

def setNumberIterations(self, iteration_count):
Expand Down
4 changes: 3 additions & 1 deletion src/ert/gui/simulation/multiple_data_assimilation_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ def __init__(
self._active_realizations_model, "config/simulation/active_realizations"
)
self._active_realizations_field.setValidator(RangeStringArgument(ensemble_size))
self._ensemble_selector = EnsembleSelector(notifier)
self._realizations_from_fs()
layout.addRow("Active realizations:", self._active_realizations_field)

self._restart_box = QCheckBox("")
Expand All @@ -94,8 +96,8 @@ def __init__(
self._restart_box.setEnabled(False)
layout.addRow("Restart run:", self._restart_box)

self._ensemble_selector = EnsembleSelector(notifier)
self._ensemble_selector.ensemble_populated.connect(self.restart_run_toggled)
self._ensemble_selector.currentIndexChanged.connect(self._realizations_from_fs)
layout.addRow("Restart from:", self._ensemble_selector)

self._target_ensemble_format_field.getValidationSupport().validationChanged.connect( # noqa
Expand Down
8 changes: 8 additions & 0 deletions src/ert/gui/simulation/simulation_config_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,11 @@ def isConfigurationValid():
@staticmethod
def getSimulationArguments() -> Dict[str, Any]:
return {}

def _realizations_from_fs(self):
ensemble = str(self._ensemble_selector.currentText())
if ensemble:
mask = self.notifier.storage.get_ensemble_by_name(
ensemble
).get_realization_mask_with_parameters()
self._active_realizations_field.model.setValueFromMask(mask)