Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect failed realizations after ert restart #7514

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Reflect failed realizations after ert restart #7514

merged 1 commit into from
Apr 18, 2024
+19 −11

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Mar 22, 2024

Issue
Resolves #7505

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@dafeda dafeda self-assigned this Mar 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (4496033) to head (ba9f7dd).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7514      +/-   ##
==========================================
- Coverage   84.79%   84.73%   -0.07%     
==========================================
  Files         383      383              
  Lines       23309    23316       +7     
  Branches      890      881       -9     
==========================================
- Hits        19766    19757       -9     
- Misses       3431     3452      +21     
+ Partials      112      107       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda force-pushed the evaluate-failed-reals branch 2 times, most recently from 2651631 to f3cfba9 Compare April 10, 2024 13:04
@dafeda
Copy link
Contributor Author

dafeda commented Apr 12, 2024 •
edited
Loading

Giving up on writing a test for this.

Have manually tested and "Evaluate ensemble" looks like this after closing and re-opening ert:

image

ES-MDA also shows the correct active realizations:

image

And IES:

image

@dafeda dafeda force-pushed the evaluate-failed-reals branch 3 times, most recently from ced2fc2 to 3c9419a Compare April 12, 2024 08:27
frode-aarstad
frode-aarstad approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@frode-aarstad frode-aarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dafeda dafeda merged commit 9e04517 into equinor:main Apr 18, 2024
37 checks passed
@dafeda dafeda deleted the evaluate-failed-reals branch April 18, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frode-aarstad frode-aarstad frode-aarstad approved these changes

Assignees

@dafeda dafeda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed realizations not reflected in run model after ert restart
3 participants
@dafeda @codecov-commenter @frode-aarstad