Add remaining states to the working STATES for LSF driver #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
added
release-notes:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7423 +/- ##
==========================================
+ Coverage 84.48% 84.49% +0.01%
==========================================
Files 384 384
Lines 22857 22864 +7
Branches 884 874 -10
==========================================
+ Hits 19310 19319 +9
Misses 3435 3435
+ Partials 112 110 -2 ☔ View full report in Codecov by Sentry. |
xjules
changed the title
berland
reviewed
Mar 12, 2024
src/ert/scheduler/lsf_driver.py
Outdated
| class FinishedJob(BaseModel): | ||
| job_state: Literal["DONE", "EXIT"] | ||
| job_state: Literal["DONE", "EXIT", "PDONE", "ZOMBI"] |
There was a problem hiding this comment.
Should we split this into two classes, one for successes and one for failures?
There was a problem hiding this comment.
Do you mean FInishedJobSuccess and FinishedJobFailure? I think it makes sense.
This commit moves status update into its own function (_process_job_udpate). Additionally, it adds two standalone states FinishedJobFailure and FinishedJobSuccess. It adds test for process_job_update that it handles all the states properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #7215
Approach
Implement a helper function
lsf_driver._process_job_updateand write tests.(Screenshot of new behavior in GUI if applicable)
When applicable