-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining states to the working STATES for LSF driver #7423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7423 +/- ##
==========================================
+ Coverage 84.48% 84.49% +0.01%
==========================================
Files 384 384
Lines 22857 22864 +7
Branches 884 874 -10
==========================================
+ Hits 19310 19319 +9
Misses 3435 3435
+ Partials 112 110 -2 ☔ View full report in Codecov by Sentry. |
src/ert/scheduler/lsf_driver.py
Outdated
class FinishedJob(BaseModel): | ||
job_state: Literal["DONE", "EXIT"] | ||
job_state: Literal["DONE", "EXIT", "PDONE", "ZOMBI"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we split this into two classes, one for successes and one for failures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean FInishedJobSuccess
and FinishedJobFailure
? I think it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jolly good
This commit moves status update into its own function (_process_job_udpate). Additionally, it adds two standalone states FinishedJobFailure and FinishedJobSuccess. It adds test for process_job_update that it handles all the states properly.
Issue
Resolves #7215
Approach
Implement a helper function
lsf_driver._process_job_update
and write tests.(Screenshot of new behavior in GUI if applicable)
When applicable