Fix summary reading being too slow in case of many summary keys to match against #7410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7262
looping over a fnmatch is too slow, especially after converting the fnmatch from c to python. Compiling a regex once is much faster, see the included test.
I ran the following test and the result of the new function seems to be identical to the old function.
I took some benchmarks using random but realistic fetch_keys and keys.
The new algorithm can sometimes perform worse when the size of
fetch_keys
is close to or smaller than the number of keys, but the old algorithm is regularly worse as the number of keys grow.