Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concurrency to cancel existing workflow jobs #7375

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Mar 6, 2024

Using concurrency groups to avoid unwanted congestion on subsequent commits.
Also set timeouts to 60 minutes where no timeout was provided.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el requested a review from larsevj March 6, 2024 14:49
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Mar 6, 2024
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@andreas-el andreas-el requested a review from larsevj March 6, 2024 15:16
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, these are already covered by the workflows they are called from. 👍

@@ -10,11 +10,15 @@ permissions:
# contents permission to update benchmark contents in gh-pages branch
contents: write

concurrency:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is redundant as this only triggers on push to main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we don't need this. I've checked the others too. 👍

Setting concurrency groups for called workflows will cancel too much
Remove concurrency from benchmark due to main only
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (06da87b) to head (21d8ae3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7375      +/-   ##
==========================================
- Coverage   85.27%   85.26%   -0.02%     
==========================================
  Files         383      384       +1     
  Lines       22778    22795      +17     
  Branches      891      874      -17     
==========================================
+ Hits        19425    19436      +11     
+ Misses       3246     3245       -1     
- Partials      107      114       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el merged commit 14a4919 into equinor:main Mar 7, 2024
63 of 66 checks passed
@andreas-el andreas-el deleted the use_concurrency_github branch March 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants