-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use concurrency to cancel existing workflow jobs #7375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, these are already covered by the workflows they are called from. 👍
.github/workflows/benchmark.yml
Outdated
@@ -10,11 +10,15 @@ permissions: | |||
# contents permission to update benchmark contents in gh-pages branch | |||
contents: write | |||
|
|||
concurrency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is redundant as this only triggers on push to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we don't need this. I've checked the others too. 👍
Setting concurrency groups for called workflows will cancel too much Remove concurrency from benchmark due to main only
63fad22
to
21d8ae3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7375 +/- ##
==========================================
- Coverage 85.27% 85.26% -0.02%
==========================================
Files 383 384 +1
Lines 22778 22795 +17
Branches 891 874 -17
==========================================
+ Hits 19425 19436 +11
+ Misses 3246 3245 -1
- Partials 107 114 +7 ☔ View full report in Codecov by Sentry. |
Using concurrency groups to avoid unwanted congestion on subsequent commits.
Also set timeouts to 60 minutes where no timeout was provided.
When applicable