Make parameter example test shrink better #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
make_parameter_example_shrink_better
branch
8 times, most recently
from
688f374
to
2c22982
Compare
eivindjahren
added
the
release-notes:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7359 +/- ##
==========================================
+ Coverage 85.25% 85.28% +0.02%
==========================================
Files 382 383 +1
Lines 22766 22771 +5
Branches 878 887 +9
==========================================
+ Hits 19410 19421 +11
+ Misses 3249 3239 -10
- Partials 107 111 +4 ☔ View full report in Codecov by Sentry. |
mortalisk
approved these changes
Mar 6, 2024
yngve-sk
reviewed
Mar 6, 2024
| decl += f'\nFORWARD_MODEL COPY_FILE(<FROM>="../../../{self.name}.{self.outext}",<TO>=.)' | ||
| return decl | ||
|
|
||
| def create(self, io_source: IoProvider, num_realizations: int): |
There was a problem hiding this comment.
consider rename to something with file
There was a problem hiding this comment.
Renamed to create_file :P
eivindjahren
force-pushed
the
make_parameter_example_shrink_better
branch
5 times, most recently
from
3b6979c
to
df69934
Compare
eivindjahren
force-pushed
the
make_parameter_example_shrink_better
branch
from
df69934
to
6398153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the parameter example test shrink to a smaller size if possible. Also has the benefit that the run time goes down as the average size is smaller.
When applicable