-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parameter example test shrink better #7359
Make parameter example test shrink better #7359
Conversation
688f374
to
2c22982
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7359 +/- ##
==========================================
+ Coverage 85.25% 85.28% +0.02%
==========================================
Files 382 383 +1
Lines 22766 22771 +5
Branches 878 887 +9
==========================================
+ Hits 19410 19421 +11
+ Misses 3249 3239 -10
- Partials 107 111 +4 ☔ View full report in Codecov by Sentry. |
decl += f'\nFORWARD_MODEL COPY_FILE(<FROM>="../../../{self.name}.{self.outext}",<TO>=.)' | ||
return decl | ||
|
||
def create(self, io_source: IoProvider, num_realizations: int): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider rename to something with file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to create_file :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3b6979c
to
df69934
Compare
df69934
to
6398153
Compare
Makes the parameter example test shrink to a smaller size if possible. Also has the benefit that the run time goes down as the average size is smaller.
When applicable