Group observations by response type #7353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
combine-observations
branch
7 times, most recently
from
0458397
to
d2fed33
Compare
yngve-sk
force-pushed
the
combine-observations
branch
6 times, most recently
from
d32c1a7
to
cb6c637
Compare
yngve-sk
changed the title
yngve-sk
force-pushed
the
combine-observations
branch
11 times, most recently
from
d2eedf6
to
7b5300d
Compare
yngve-sk
force-pushed
the
combine-observations
branch
2 times, most recently
from
85552da
to
a07b2e4
Compare
yngve-sk
force-pushed
the
combine-observations
branch
19 times, most recently
from
b63bca4
to
ca17ac3
Compare
added 9 commits
March 21, 2024 09:09
Note: Updates in numbers to test_update_snapshot are assumed to be OK (need to double check). They change because observations are now always ordered by obsname->key_index (time for summary, "index,report_step" for gen_data)
Reason: Observations are only passed through to initialize LocalExperiment, from which they are accessed when getting MeasuredData, which is where the sorting should and is now being done.
yngve-sk
force-pushed
the
combine-observations
branch
from
ca17ac3
to
c43f980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #7279
Adds one dataset per response type, rather than one per observation key. Should speed up things some/quite a bit, especially for cases where the amount of observations by far exceeds the number of responses.