Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from using flaky to pytest_rerunfailures #7346

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

jonathan-eq
Copy link
Contributor

Issue
Resolves #7332

Approach
Changes from using flaky to pytest_rerunfailures

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-assigned this Mar 4, 2024
@jonathan-eq jonathan-eq added bug release-notes:skip If there should be no mention of this in release notes labels Mar 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (c385d31) to head (d58ede2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7346      +/-   ##
==========================================
- Coverage   85.23%   84.53%   -0.70%     
==========================================
  Files         382      382              
  Lines       22740    22740              
  Branches      884      880       -4     
==========================================
- Hits        19382    19223     -159     
- Misses       3248     3404     +156     
- Partials      110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-eq jonathan-eq merged commit 126ac6b into equinor:main Mar 4, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Alternatives to flaky?
3 participants