-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misfit config so it is possible to configure a subset of observations #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
force-pushed
the
fix_misfit_config
branch
from
February 25, 2024 21:15
51a678b
to
0691b8b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7263 +/- ##
==========================================
+ Coverage 85.23% 85.25% +0.02%
==========================================
Files 386 387 +1
Lines 23031 23058 +27
Branches 874 889 +15
==========================================
+ Hits 19631 19659 +28
- Misses 3290 3291 +1
+ Partials 110 108 -2 ☔ View full report in Codecov by Sentry. |
oyvindeide
force-pushed
the
fix_misfit_config
branch
5 times, most recently
from
February 28, 2024 08:54
109d155
to
7754b06
Compare
oyvindeide
commented
Feb 28, 2024
oyvindeide
commented
Feb 28, 2024
oyvindeide
added
the
release-notes:bug-fix
Automatically categorise as bug fix in release notes
label
Feb 28, 2024
sondreso
reviewed
Feb 28, 2024
oyvindeide
force-pushed
the
fix_misfit_config
branch
7 times, most recently
from
March 14, 2024 08:51
9363b37
to
76dcb09
Compare
oyvindeide
changed the title
Fix misfit config
Fix misfit config so it is possible to configure a subset of observations
Mar 14, 2024
sondreso
reviewed
Mar 14, 2024
oyvindeide
force-pushed
the
fix_misfit_config
branch
2 times, most recently
from
March 14, 2024 14:26
b98ef0e
to
bcf2fef
Compare
sondreso
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
oyvindeide
force-pushed
the
fix_misfit_config
branch
from
March 15, 2024 14:09
bcf2fef
to
8466fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #7211
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable