Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misfit config so it is possible to configure a subset of observations #7263

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Feb 25, 2024

Issue
Resolves #7211

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 88.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.25%. Comparing base (819de94) to head (8466fdf).

Files Patch % Lines
...k_implementations/workflows/misfit_preprocessor.py 53.84% 6 Missing ⚠️
...rc/ert/gui/tools/run_analysis/run_analysis_tool.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7263      +/-   ##
==========================================
+ Coverage   85.23%   85.25%   +0.02%     
==========================================
  Files         386      387       +1     
  Lines       23031    23058      +27     
  Branches      874      889      +15     
==========================================
+ Hits        19631    19659      +28     
- Misses       3290     3291       +1     
+ Partials      110      108       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide force-pushed the fix_misfit_config branch 5 times, most recently from 109d155 to 7754b06 Compare February 28, 2024 08:54
@oyvindeide oyvindeide self-assigned this Feb 28, 2024
@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Feb 28, 2024
src/ert/analysis/_es_update.py Show resolved Hide resolved
src/ert/analysis/_es_update.py Outdated Show resolved Hide resolved
src/ert/config/analysis_config.py Outdated Show resolved Hide resolved
src/ert/config/analysis_config.py Show resolved Hide resolved
@oyvindeide oyvindeide force-pushed the fix_misfit_config branch 7 times, most recently from 9363b37 to 76dcb09 Compare March 14, 2024 08:51
@oyvindeide oyvindeide changed the title Fix misfit config Fix misfit config so it is possible to configure a subset of observations Mar 14, 2024
@oyvindeide oyvindeide force-pushed the fix_misfit_config branch 2 times, most recently from b98ef0e to bcf2fef Compare March 14, 2024 14:26
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oyvindeide oyvindeide merged commit 037606a into equinor:main Mar 15, 2024
34 checks passed
@oyvindeide oyvindeide deleted the fix_misfit_config branch March 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add config option to run misfit_preprocessor
3 participants