Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracker and tracker_worker #6811

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

sondreso
Copy link
Collaborator

@sondreso sondreso commented Dec 14, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 85.76%. Comparing base (ea34ecc) to head (4fad2f9).

Files Patch % Lines
src/ert/run_models/base_run_model.py 73.95% 25 Missing ⚠️
src/ert/gui/simulation/queue_emitter.py 62.50% 3 Missing ⚠️
src/ert/cli/main.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6811      +/-   ##
==========================================
+ Coverage   85.74%   85.76%   +0.01%     
==========================================
  Files         383      382       -1     
  Lines       23266    23241      -25     
  Branches      893      877      -16     
==========================================
- Hits        19950    19932      -18     
+ Misses       3206     3196      -10     
- Partials      110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sondreso sondreso force-pushed the no-tracker branch 2 times, most recently from 7660192 to bbf5aa7 Compare January 25, 2024 16:05
@oyvindeide
Copy link
Collaborator

A very non-scientific test, but test_cli.py was 30% faster in this branch vs main

src/ert/cli/main.py Outdated Show resolved Hide resolved
@sondreso sondreso force-pushed the no-tracker branch 2 times, most recently from 8cf334e to 395eccc Compare January 30, 2024 09:59
@xjules
Copy link
Contributor

xjules commented Mar 22, 2024

Would it be realistic to make the monitor.py fully async? Not at the least to get rid of the duplexer.
Update: I have a Monitor_async.py version in my PR: #6994 I've managed to go without in that PR but still have a version available.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really nice improvement 🎖️

@oyvindeide oyvindeide marked this pull request as ready for review April 22, 2024 10:38
@oyvindeide oyvindeide merged commit 8c16ed9 into equinor:main Apr 22, 2024
37 checks passed
@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Apr 22, 2024
@sondreso sondreso deleted the no-tracker branch April 22, 2024 12:32
@eivindjahren eivindjahren mentioned this pull request Apr 23, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants