Decrease timeout when connecting to websocket #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set timeout in wait_for_evaluator Without this, ert will wait for 60s before letting users know that a workflow has failed. Co-authored-by: Sondre <[email protected]>
dafeda
added
the
release-notes:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6730 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 359 359
Lines 20952 20953 +1
Branches 948 948
=======================================
+ Hits 17509 17510 +1
Misses 3149 3149
Partials 294 294 ☔ View full report in Codecov by Sentry. |
oyvindeide
approved these changes
Dec 1, 2023
oyvindeide
reviewed
Dec 1, 2023
| base_url=self._hc_uri, | ||
| token=self._token, | ||
| cert=self._cert, | ||
| base_url=self._hc_uri, token=self._token, cert=self._cert, timeout=5 |
There was a problem hiding this comment.
Use open_timeout instead of hard_coding it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set timeout in wait_for_evaluator
Without this, ert will wait for 60s before letting users know that a workflow has failed.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist