Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cutting suggestions with angular chars #6728

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Nov 30, 2023

Issue
Resolves #6729

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el self-assigned this Nov 30, 2023
@andreas-el andreas-el added the release-notes:skip If there should be no mention of this in release notes label Nov 30, 2023
@andreas-el andreas-el force-pushed the fix_qlabels_cutting_suggestions_with_angulars branch from e6907bd to a55b0e7 Compare November 30, 2023 12:28
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreas-el andreas-el enabled auto-merge (rebase) November 30, 2023 12:38
@andreas-el andreas-el merged commit 93c1d83 into equinor:main Nov 30, 2023
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestor cuts feedback containing angular characters
2 participants