Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-commit for testing style #6720

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 29, 2023

After the addition of ruff, the style check is really fast, and I have personally used this configuration for a while now, which removes the problem of committing something, only to notice style is failing.

This is of course opt-in, which means no one is forced to use it locally, it is fully voluntary.

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@oyvindeide oyvindeide added the release-notes:skip If there should be no mention of this in release notes label Nov 29, 2023
@oyvindeide oyvindeide self-assigned this Nov 30, 2023
@oyvindeide oyvindeide force-pushed the use_pre_commit branch 3 times, most recently from 730ad1c to 486cc7b Compare November 30, 2023 07:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86a31ef) 83.56% compared to head (77dfdea) 83.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6720   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files         359      359           
  Lines       20952    20953    +1     
  Branches      948      948           
=======================================
+ Hits        17509    17510    +1     
  Misses       3149     3149           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide force-pushed the use_pre_commit branch 14 times, most recently from 4e2da12 to 2bb56d0 Compare November 30, 2023 14:53
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

@oyvindeide oyvindeide merged commit 82739b1 into equinor:main Dec 1, 2023
42 of 44 checks passed
@oyvindeide oyvindeide deleted the use_pre_commit branch December 1, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants