-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test tracking #6701
Fix test tracking #6701
Conversation
55dd081
to
b46e985
Compare
@@ -347,6 +362,8 @@ async def execute( | |||
await self._statechanges_to_publish.put(CLOSE_PUBLISHER_SENTINEL) | |||
return EVTYPE_ENSEMBLE_CANCELLED | |||
|
|||
await asyncio.sleep(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved here to allow async tasks to get done before we test for active-ness (slightly scary)
b46e985
to
0f11027
Compare
print(" done") | ||
|
||
if state._callback_status_msg != "": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this flipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks strange but is copied directly from the existing job_queue_node, and it must be this way to pass tests ;)
src/ert/scheduler/scheduler.py
Outdated
return callback_status | ||
|
||
async def run_timeout_callback(self, realization: RealizationState) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should unify calling this state and not realization I think; ie. run_timeout_callback(self, state: RealizationState)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a few comments, but otherwise looks good!
0f11027
to
8afa972
Compare
Ensure storage state is set correctly when runs fail. Adjust error string building Passes test_tracking_integration
8afa972
to
b32b42b
Compare
Repaired erroneous force push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
Issue
Resolves #6694
Approach
Implement run_timeout_callback and run_exit_callback