Fix test tracking #6701
Merged
Fix test tracking #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
fix_test_tracking
branch
from
55dd081
to
b46e985
Compare
berland
commented
Nov 29, 2023
| @@ -347,6 +362,8 @@ async def execute( | |||
| await self._statechanges_to_publish.put(CLOSE_PUBLISHER_SENTINEL) | |||
| return EVTYPE_ENSEMBLE_CANCELLED | |||
|
|
|||
| await asyncio.sleep(1) | |||
There was a problem hiding this comment.
Moved here to allow async tasks to get done before we test for active-ness (slightly scary)
berland
force-pushed
the
fix_test_tracking
branch
from
b46e985
to
0f11027
Compare
kwinkunks
reviewed
Nov 29, 2023
xjules
reviewed
Nov 29, 2023
xjules
reviewed
Nov 29, 2023
| print(" done") | ||
|
|
||
| if state._callback_status_msg != "": |
There was a problem hiding this comment.
This looks strange but is copied directly from the existing job_queue_node, and it must be this way to pass tests ;)
xjules
reviewed
Nov 29, 2023
src/ert/scheduler/scheduler.py
Outdated
| return callback_status | ||
|
|
||
| async def run_timeout_callback(self, realization: RealizationState) -> None: |
There was a problem hiding this comment.
We should unify calling this state and not realization I think; ie. run_timeout_callback(self, state: RealizationState)
xjules
requested changes
Nov 29, 2023
berland
force-pushed
the
fix_test_tracking
branch
from
0f11027
to
8afa972
Compare
Ensure storage state is set correctly when runs fail. Adjust error string building Passes test_tracking_integration
berland
force-pushed
the
fix_test_tracking
branch
from
8afa972
to
b32b42b
Compare
|
Repaired erroneous force push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #6694
Approach
Implement run_timeout_callback and run_exit_callback