Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back port changes that speed up summary loading #6133

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Back port changes that speed up summary loading #6133

merged 2 commits into from
Sep 21, 2023

Conversation

oyvindeide
Copy link
Collaborator

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

eivindjahren and others added 2 commits September 21, 2023 15:34
@eivindjahren @oyvindeide
Go back to c implementation of summary loading
baebba2 
This removes the following unwanted behaviors of the current
implementation:

* The call to _init_numpy_vector_interp changes some values, probably due to interpolation.
* Iterating over ecl_sum uses both ecl_smspec_node->key1 and ecl_smspec_node->key2 which
  will result in duplicate entries for summary keyword types that have both types.
* DATE is included in the values loaded

However, the following behavior is kept from the most recent implementation:

* All report steps are loaded, not just those in the time map.
@oyvindeide
Remove duplicates from summary files
cfafc3c
@oyvindeide oyvindeide changed the title Speed summary Back port changes that speed up summary loading Sep 21, 2023
@oyvindeide oyvindeide merged commit 33178ef into equinor:version-6.0 Sep 21, 2023
42 checks passed
@oyvindeide oyvindeide deleted the speed_summary branch September 21, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oyvindeide @sondreso @eivindjahren