Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict setuptools_scm to <8 #6124

Closed
wants to merge 1 commit into from

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Sep 20, 2023

version 8 causes issues with ert's version number variable

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

version 8 causes issues with ert's version number variable
@JHolba JHolba self-assigned this Sep 20, 2023
@JHolba JHolba added the release-notes:skip If there should be no mention of this in release notes label Sep 20, 2023
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JHolba JHolba enabled auto-merge (rebase) September 20, 2023 11:28
@codecov-commenter
Copy link

Codecov Report

Merging #6124 (77315b2) into main (c1ab4e6) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6124   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files         350      350           
  Lines       21442    21442           
  Branches      834      834           
=======================================
  Hits        17687    17687           
  Misses       3457     3457           
  Partials      298      298           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide closed this Sep 20, 2023
auto-merge was automatically disabled September 20, 2023 11:45

Pull request was closed

@oyvindeide
Copy link
Collaborator

I closed this as it will be fixed upstream in a few minutes

@JHolba JHolba deleted the lock-setuptools-scm-version branch September 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants