Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sortedcontainers to install_requires #6115

Conversation

eivindjahren
Copy link
Contributor

It is required for a working system now.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

It is required for a working system now.
@eivindjahren eivindjahren self-assigned this Sep 20, 2023
@eivindjahren eivindjahren added the release-notes:dependency Automatically categorise as dependency change in release notes label Sep 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6115 (ae708c4) into main (1d153e7) will increase coverage by 16.79%.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #6115       +/-   ##
===========================================
+ Coverage   65.65%   82.45%   +16.79%     
===========================================
  Files         349      350        +1     
  Lines       21481    21442       -39     
  Branches      813      834       +21     
===========================================
+ Hits        14104    17680     +3576     
+ Misses       7084     3464     -3620     
- Partials      293      298        +5     

see 134 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eivindjahren eivindjahren merged commit c1ab4e6 into equinor:main Sep 20, 2023
40 of 41 checks passed
@eivindjahren eivindjahren deleted the make_sorted_containers_install_requires branch September 20, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:dependency Automatically categorise as dependency change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants