Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin setuptools #6113

Closed
wants to merge 1 commit into from
Closed

Unpin setuptools #6113

wants to merge 1 commit into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 19, 2023

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda force-pushed the unpin_setuptools branch 4 times, most recently from 04cdede to 3c39765 Compare September 19, 2023 14:09
@dafeda
Copy link
Contributor Author

dafeda commented Sep 20, 2023

Editable installs do not work when using scikit-build with newer versions of setuptools.

https://scikit-build.readthedocs.io/en/latest/#known-issues

@dafeda dafeda closed this Dec 11, 2023
@dafeda dafeda deleted the unpin_setuptools branch December 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant