Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup.cfg and use pyproject.toml instead #6086

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Remove setup.cfg and use pyproject.toml instead #6086

merged 1 commit into from
Sep 19, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 12, 2023 •
edited
Loading

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 12, 2023
berland
berland reviewed Sep 12, 2023
View reviewed changes
style-requirements.txt Outdated
@@ -2,6 +2,7 @@ cmake-format
flake8
flake8-bugbear
flake8-simplify
Flake8-pyproject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower-case 'f' to be consistent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and maybe keep alphabetically sorting)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using upper-case because it's what the project is called: https://pypi.org/project/Flake8-pyproject/

I've changed the order to alphabetical.

@dafeda
Remove setup.cfg, use pyproject.toml instead
44dd569 
Flake8-pyproject is needed as flake8 does not support pyproject.toml
out of the box.
@dafeda dafeda changed the title Remove test alias from setup.cfg Remove setup.cfg and use pyproject.toml instead Sep 18, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 18, 2023
berland
berland approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@dafeda dafeda merged commit af3e842 into equinor:main Sep 19, 2023
40 of 42 checks passed
@dafeda dafeda deleted the alias branch September 19, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees

@dafeda dafeda

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafeda @berland