Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant installs from dev-reqs #6085

Closed
wants to merge 0 commits into from
Closed

Remove redundant installs from dev-reqs #6085

wants to merge 0 commits into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 12, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 12, 2023
yngve-sk
yngve-sk approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it could also be removed from pyproject.toml, as I'm not finding any references to it outside the typing.yml GH workflow.

@dafeda dafeda force-pushed the grpcio_snyk branch 2 times, most recently from c63b8ba to e9e6c82 Compare September 17, 2023 06:35
@dafeda
Copy link
Contributor Author

dafeda commented Sep 17, 2023

LGTM. I think it could also be removed from pyproject.toml, as I'm not finding any references to it outside the typing.yml GH workflow.

I tried removing from pyproject.toml but then building linux wheels fails.
Have not investigated much.

@dafeda dafeda changed the title Remove redundant install of grcpio-tools Remove redundant installs from dev-reqs Sep 18, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 18, 2023
@dafeda dafeda force-pushed the grpcio_snyk branch 2 times, most recently from a9cfcf7 to 59653e0 Compare September 25, 2023 06:22
@dafeda dafeda closed this Sep 26, 2023
@dafeda dafeda deleted the grpcio_snyk branch February 3, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngve-sk yngve-sk yngve-sk approved these changes

Assignees

@dafeda dafeda

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafeda @yngve-sk