Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move style requirements to separate file #6081

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 12, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 12, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 12, 2023
Copy link
Contributor

@JHolba JHolba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a nice change. probably makes the style checking on github quicker too.

@dafeda dafeda merged commit 7c1fa43 into equinor:main Sep 12, 2023
38 of 40 checks passed
@dafeda dafeda deleted the style_reqs branch September 12, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants