Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jobs array with job_queue_node_type vector #6077

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Replace jobs array with job_queue_node_type vector #6077

merged 7 commits into from
Sep 19, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 11, 2023 •
edited
Loading

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el force-pushed the refactor_job_list branch 5 times, most recently from 91d5f16 to 367e7e8 Compare September 11, 2023 18:13
@andreas-el andreas-el self-assigned this Sep 11, 2023
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 11, 2023
@andreas-el andreas-el force-pushed the refactor_job_list branch 3 times, most recently from 586b637 to 6d4dbd5 Compare September 18, 2023 13:16
@andreas-el andreas-el changed the title Replace **jobs array with std::vector<job_queue_node_type *> Replace jobs array with job_queue_node_type vector Sep 18, 2023
eivindjahren
eivindjahren approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreas-el andreas-el merged commit bfbd5f3 into equinor:main Sep 19, 2023
42 checks passed
@andreas-el andreas-el deleted the refactor_job_list branch September 19, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees

@andreas-el andreas-el

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreas-el @eivindjahren