Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor local_driver and handling of generic options #6061

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 7, 2023

Lift name property and remove generic options handling.
Names are now fetched from enum, and 'local' was turned into 'LOCAL' as a result of that.
Add tests for local_driver get/set_option that will do util_abort.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

Codecov Report

Merging #6061 (01c078a) into main (89e8e13) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 25.80%.

@@            Coverage Diff             @@
##             main    #6061      +/-   ##
==========================================
- Coverage   82.66%   82.56%   -0.10%     
==========================================
  Files         352      349       -3     
  Lines       21812    21480     -332     
  Branches      817      813       -4     
==========================================
- Hits        18031    17736     -295     
+ Misses       3485     3451      -34     
+ Partials      296      293       -3     
Files Changed Coverage Δ
src/clib/lib/job_queue/local_driver.cpp 11.76% <4.16%> (-1.97%) ⬇️
src/clib/lib/job_queue/queue_driver.cpp 95.45% <100.00%> (+7.21%) ⬆️
src/ert/job_queue/driver.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andreas-el andreas-el self-assigned this Sep 11, 2023
@andreas-el andreas-el force-pushed the refactor_drivers branch 8 times, most recently from 9746c4a to 6dcf0f3 Compare September 11, 2023 08:44
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 11, 2023
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sky is the limit :-)

@andreas-el andreas-el merged commit 1d153e7 into equinor:main Sep 18, 2023
41 of 42 checks passed
@andreas-el andreas-el deleted the refactor_drivers branch September 18, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants