Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry current case bug and 32 bit field loading and saving of fields #6052

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Cherry current case bug and 32 bit field loading and saving of fields #6052

merged 3 commits into from
Sep 6, 2023

Conversation

oyvindeide
Copy link
Collaborator

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured new behaviour is tested (opened GUI? screenshots? tried workflows?)

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@oyvindeide oyvindeide changed the base branch from main to version-5.0 September 5, 2023 15:23
@oyvindeide oyvindeide changed the title Cherry pick speed Cherry current case bug and 32 bit field loading and saving of fields Sep 5, 2023
@oyvindeide oyvindeide force-pushed the cherry-pick-speed branch 2 times, most recently from cede531 to ea34686 Compare September 6, 2023 07:42
dafeda
dafeda approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this by running esmda on Drogon and it seems to do the right thing.

@oyvindeide oyvindeide merged commit efa1e62 into equinor:version-5.0 Sep 6, 2023
33 of 35 checks passed
@oyvindeide oyvindeide deleted the cherry-pick-speed branch September 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeda dafeda dafeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyvindeide @dafeda