Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add warning when overwriting QUEUE_OPTION (#5993)" #6032

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Revert "Add warning when overwriting QUEUE_OPTION (#5993)" #6032

merged 1 commit into from
Sep 1, 2023

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Sep 1, 2023 •
edited
Loading

This reverts commit 1c92495.

Remove unwarranted warnings.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Wait for tests in CI to pass (see "checks" below)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured new behaviour is tested (opened GUI? screenshots? tried workflows?)
  • Commit history is consistent and clean, in line with the contribution guidelines.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution
    guidelines    .

@larsevj larsevj self-assigned this Sep 1, 2023
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Sep 1, 2023
berland
berland approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@larsevj larsevj merged commit 90bfe2c into equinor:main Sep 1, 2023
39 of 40 checks passed
@larsevj larsevj deleted the RevertOverwritingQUEUE_OPTION branch September 4, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees

@larsevj larsevj

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsevj @berland